viirya commented on code in PR #7378:
URL: https://github.com/apache/arrow-datafusion/pull/7378#discussion_r1303231584
##########
datafusion/sqllogictest/test_files/predicates.slt:
##########
@@ -249,6 +249,40 @@ SELECT * FROM test WHERE column1 IN ('foo', 'Bar', 'fazzz')
foo
fazzz
+statement ok
+CREATE TABLE IF NOT EXISTS test_float AS
VALUES(1.2),(2.1),(NULL),('NaN'::double),('-NaN'::double);
+
+# async fn in_list_float
Review Comment:
`async fn csv_query_with_predicate()`? I believe it was left when the test
was migrated to sqllogictest as I can search it in commit log. Don't know why
it was left, it is useless.
As you are not migrating old test, it is no point to have it, I think.
##########
datafusion/sqllogictest/test_files/predicates.slt:
##########
@@ -249,6 +249,40 @@ SELECT * FROM test WHERE column1 IN ('foo', 'Bar', 'fazzz')
foo
fazzz
+statement ok
+CREATE TABLE IF NOT EXISTS test_float AS
VALUES(1.2),(2.1),(NULL),('NaN'::double),('-NaN'::double);
+
+# async fn in_list_float
Review Comment:
`async fn csv_query_with_predicate()`? I believe it was left when the test
was migrated to sqllogictest as I can search it in commit log. Don't know why
it was left, it is useless.
As you are not migrate old test, it is no point to have it, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
