viirya commented on code in PR #7378:
URL: https://github.com/apache/arrow-datafusion/pull/7378#discussion_r1302200666
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -94,7 +94,7 @@ impl<T> Set for ArraySet<T>
where
T: Array + 'static,
for<'a> &'a T: ArrayAccessor,
- for<'a> <&'a T as ArrayAccessor>::Item: PartialEq + HashValue,
+ for<'a> <&'a T as ArrayAccessor>::Item: IsEqual + HashValue,
Review Comment:
As IsEqual: HashValue, we can remove HashValue here?
##########
datafusion/physical-expr/src/expressions/in_list.rs:
##########
@@ -141,7 +141,7 @@ where
fn make_hash_set<T>(array: T) -> ArrayHashSet
where
T: ArrayAccessor,
- T::Item: PartialEq + HashValue,
+ T::Item: IsEqual + HashValue,
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
