viirya commented on code in PR #7378:
URL: https://github.com/apache/arrow-datafusion/pull/7378#discussion_r1303195572
##########
datafusion/sqllogictest/test_files/predicates.slt:
##########
@@ -249,6 +249,40 @@ SELECT * FROM test WHERE column1 IN ('foo', 'Bar', 'fazzz')
foo
fazzz
+statement ok
+CREATE TABLE IF NOT EXISTS test_float AS
VALUES(1.2),(2.1),(NULL),('NaN'::double),('-NaN'::double);
+
+# async fn in_list_float
Review Comment:
```suggestion
```
##########
datafusion/sqllogictest/test_files/predicates.slt:
##########
@@ -249,6 +249,40 @@ SELECT * FROM test WHERE column1 IN ('foo', 'Bar', 'fazzz')
foo
fazzz
+statement ok
+CREATE TABLE IF NOT EXISTS test_float AS
VALUES(1.2),(2.1),(NULL),('NaN'::double),('-NaN'::double);
+
+# async fn in_list_float
+query R
+SELECT * FROM test_float WHERE column1 IN (0.0, -1.2)
+----
+
+query R
+SELECT * FROM test_float WHERE column1 IN (0.0, 1.2)
+----
+1.2
+
+query R
+SELECT * FROM test_float WHERE column1 IN (2.1, 1.2)
+----
+1.2
+2.1
+
+query R
+SELECT * FROM test_float WHERE column1 IN (0.0, 1.2, NULL)
+----
+1.2
+
+query R
+SELECT * FROM test_float WHERE column1 IN (0.0, -1.2, NULL)
+----
+
+query R
+SELECT * FROM test_float WHERE column1 IN (0.0, 1.2, 'NaN'::double,
'-NaN'::double)
+----
+1.2
+NaN
+NaN
Review Comment:
Hmm, shouldn't it be -NaN?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
