davidhcoe commented on code in PR #1183:
URL: https://github.com/apache/arrow-adbc/pull/1183#discussion_r1350398788
##########
csharp/test/Drivers/Snowflake/SnowflakeTestConfiguration.cs:
##########
@@ -71,5 +71,17 @@ internal class SnowflakeTestConfiguration : TestConfiguration
/// </summary>
[JsonPropertyName("authenticationTokenPath"), JsonIgnore(Condition =
JsonIgnoreCondition.WhenWritingDefault)]
public string AuthenticationTokenPath { get; set; }
+
+ /// <summary>
+ /// The snowflake copy command. E.g. "copy into {0} from @%{1}
file_format = (type = 'parquet');"
+ /// </summary>
+ [JsonPropertyName("copyCommand")]
+ public string copyCommand { get; set; }
Review Comment:
The property should be named `CopyCommand` to match the other naming
conventions.
##########
csharp/src/Client/SchemaConverter.cs:
##########
@@ -58,15 +61,20 @@ public static DataTable ConvertArrowSchema(Schema schema,
AdbcStatement adbcStat
row[SchemaTableColumn.ColumnName] = f.Name;
row[SchemaTableColumn.ColumnOrdinal] = columnOrdinal;
row[SchemaTableColumn.AllowDBNull] = f.IsNullable;
- row[SchemaTableColumn.ProviderType] = f.DataType;
+ row[ArrowTypeName] = f.DataType;
Type t = ConvertArrowType(f);
row[SchemaTableColumn.DataType] = t;
+ if (f.HasMetadata && f.Metadata.ContainsKey("logicalType"))
Review Comment:
In general, this is a nice introduction. However, `logicalType` is specific
to Snowflake. How can this be generic for different drivers?
##########
csharp/test/Drivers/Snowflake/ClientTests.cs:
##########
@@ -221,6 +221,86 @@ public void VerifyTypesAndValues()
}
}
+ [Test, Order(6)]
+ public void CanClientExecuteStageCommand()
Review Comment:
What do the stage and copy commands add that you can't do with the existing
`Query` value? Instead of being configurable with a different test
configuration (set via the environment variable), it now adds separate queries
and has a fixed result (1) instead of being configurable.
##########
csharp/test/Drivers/Snowflake/SnowflakeTestConfiguration.cs:
##########
@@ -71,5 +71,17 @@ internal class SnowflakeTestConfiguration : TestConfiguration
/// </summary>
[JsonPropertyName("authenticationTokenPath"), JsonIgnore(Condition =
JsonIgnoreCondition.WhenWritingDefault)]
public string AuthenticationTokenPath { get; set; }
+
+ /// <summary>
+ /// The snowflake copy command. E.g. "copy into {0} from @%{1}
file_format = (type = 'parquet');"
+ /// </summary>
+ [JsonPropertyName("copyCommand")]
+ public string copyCommand { get; set; }
+
+ /// <summary>
+ /// The snowflake stage command. E.g. "create or replace stage {0} url
= {1} credentials = (AZURE_SAS_TOKEN = {2}) file_format = (type = 'parquet');"
+ /// </summary>
+ [JsonPropertyName("stageCommand")]
+ public string stageCommand { get; set; }
Review Comment:
The property should be named `StageCommand` to match the other naming
conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
