ruowan commented on code in PR #1183:
URL: https://github.com/apache/arrow-adbc/pull/1183#discussion_r1351514729


##########
csharp/test/Drivers/Snowflake/ClientTests.cs:
##########
@@ -221,6 +221,86 @@ public void VerifyTypesAndValues()
             }
         }
 
+        [Test, Order(6)]
+        public void CanClientExecuteStageCommand()

Review Comment:
   In our current architecture, changing environment variables to switch config 
file is necessary for different test cases. Maybe we could do some refactor to 
decouple the query and authentication config.  This could eliminate the need 
for multiple config files and switching environment variables.
   
   This is my proposal.
   - The config file should only support different auth type with auth 
credentials.
   - In each test, we can have some data prepare before test case run. And 
store query and expected result in separate place.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to