ruowan commented on code in PR #1183:
URL: https://github.com/apache/arrow-adbc/pull/1183#discussion_r1351505261
##########
csharp/src/Client/SchemaConverter.cs:
##########
@@ -58,15 +61,20 @@ public static DataTable ConvertArrowSchema(Schema schema,
AdbcStatement adbcStat
row[SchemaTableColumn.ColumnName] = f.Name;
row[SchemaTableColumn.ColumnOrdinal] = columnOrdinal;
row[SchemaTableColumn.AllowDBNull] = f.IsNullable;
- row[SchemaTableColumn.ProviderType] = f.DataType;
+ row[ArrowTypeName] = f.DataType;
Type t = ConvertArrowType(f);
row[SchemaTableColumn.DataType] = t;
+ if (f.HasMetadata && f.Metadata.ContainsKey("logicalType"))
Review Comment:
Can each driver use a distinct schemaConverter? The common
schemaConverter.cs preserves all metadata and each driver schemaConverter could
based on their requirement and do some customization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
