comphead commented on code in PR #8402:
URL: https://github.com/apache/arrow-datafusion/pull/8402#discussion_r1413023394
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -503,7 +503,10 @@ fn coerce_window_frame(
let target_type = match window_frame.units {
WindowFrameUnits::Range => {
if let Some(col_type) = current_types.first() {
- if col_type.is_numeric() || is_utf8_or_large_utf8(col_type) {
+ if col_type.is_numeric()
+ || is_utf8_or_large_utf8(col_type)
+ || matches!(col_type, DataType::Null)
Review Comment:
yes, the test tests also nulls in window spec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
