alamb opened a new pull request, #8713: URL: https://github.com/apache/arrow-datafusion/pull/8713
## Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/8712 ## Rationale for this change `ScalarUDF` is a struct of function pointers for historical reasons. After https://github.com/apache/arrow-datafusion/pull/8578, `ScalarUDFImpl` is available, we can clean up its internal implementation to be in terms of that trait directly, simplifying the implementation greatly. ## What changes are included in this PR? 1. Rewrite `ScalarUDF` to have a single `Arc<dyn ScalarUDFImpl` field 2. Add `+Debug` to `ScalarUDFImpl` which forces implementations to also derive Debug which I think is much better than the opaque `FUNC` that was there previously ## Are these changes tested? yes ## Are there any user-facing changes? New requirement to derive `Debug` for `ScalarUDFImpl` but I think that is good hygene anyways <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
