alamb commented on code in PR #8713:
URL: https://github.com/apache/arrow-datafusion/pull/8713#discussion_r1439077929


##########
datafusion/expr/src/expr.rs:
##########
@@ -1948,6 +1948,7 @@ mod test {
         );
 
         // UDF
+        #[derive(Debug)]

Review Comment:
   This is an example of the API change -- any new impl of `ScalarUDFImpl` must 
also derive `Debug` -- note that `ScalarUDFImpl` was introduced in 
https://github.com/apache/arrow-datafusion/pull/8578 and not yet released so 
this is not a breaking change for released versions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to