alamb commented on code in PR #8713: URL: https://github.com/apache/arrow-datafusion/pull/8713#discussion_r1439078079
########## datafusion/expr/src/udf.rs: ########## @@ -35,57 +36,35 @@ use std::sync::Arc; /// functions you supply such name, type signature, return type, and actual /// implementation. /// -/// /// 1. For simple (less performant) use cases, use [`create_udf`] and [`simple_udf.rs`]. /// /// 2. For advanced use cases, use [`ScalarUDFImpl`] and [`advanced_udf.rs`]. /// +/// # API Note Review Comment: As I went through this PR, `ScalarUDF` is now basically a pass through wrapper to `ScalarUDFImpl` -- if we didn't want to maintain backwards compatibility we could probably simply remove the `ScalarUDF` struct and make it a trait, but I think that would be super disruptive to all exisiting users of DataFusion so I think we should avoid doing so unless absolutely necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
