alamb commented on code in PR #8713:
URL: https://github.com/apache/arrow-datafusion/pull/8713#discussion_r1439077929
##########
datafusion/expr/src/expr.rs:
##########
@@ -1948,6 +1948,7 @@ mod test {
);
// UDF
+ #[derive(Debug)]
Review Comment:
This is an example of the API change (of the API introduced in
https://github.com/apache/arrow-datafusion/pull/8578)
##########
datafusion/expr/src/udf.rs:
##########
@@ -35,57 +36,35 @@ use std::sync::Arc;
/// functions you supply such name, type signature, return type, and actual
/// implementation.
///
-///
/// 1. For simple (less performant) use cases, use [`create_udf`] and
[`simple_udf.rs`].
///
/// 2. For advanced use cases, use [`ScalarUDFImpl`] and [`advanced_udf.rs`].
///
+/// # API Note
Review Comment:
As I went through this PR, `ScalarUDF` is now basically a pass through
wrapper to `ScalarUDFImpl` -- if we didn't have to maintain backwards
compatibility we could probably simply make ScalarUDF a trait (as it ideally
would have been initially)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
