alamb commented on code in PR #8730:
URL: https://github.com/apache/arrow-datafusion/pull/8730#discussion_r1440832093
##########
.github/workflows/rust.yml:
##########
@@ -302,9 +309,10 @@ jobs:
cargo test --lib --tests --bins --all-features
env:
# do not produce debug symbols to keep memory usage down
- RUSTFLAGS: "-C debuginfo=0"
+ RUSTFLAGS: "-C debuginfo=0 -C opt-level=1 -C
target-feature=+crt-static -C incremental=false -C codegen-units=256"
Review Comment:
Can we also please add a comment explaining why we are using `opt-level` (so
future readers know the rationale).
Maybe something like
```suggestion
# use higher optimziation level to speed builds:
https://github.com/apache/arrow-datafusion/issues/8696
RUSTFLAGS: "-C debuginfo=0 -C opt-level=1 -C
target-feature=+crt-static -C incremental=false -C codegen-units=256"
```
##########
.github/workflows/rust.yml:
##########
@@ -99,6 +99,12 @@ jobs:
rust-version: stable
- name: Run tests (excluding doctests)
run: cargo test --lib --tests --bins --features avro,json,backtrace
+ env:
+ # do not produce debug symbols to keep memory usage down
Review Comment:
What is the rationale for changing these options in the linux (and mac)
builds -- I would prefer to keep the CI options as close as possible to how
developers run so there is less opportunity for things to work locally / fail
only on CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
