comphead commented on code in PR #8730:
URL: https://github.com/apache/arrow-datafusion/pull/8730#discussion_r1440986875
##########
.github/workflows/rust.yml:
##########
@@ -338,8 +352,12 @@ jobs:
cargo test --lib --tests --bins --all-features
env:
# do not produce debug symbols to keep memory usage down
- RUSTFLAGS: "-C debuginfo=0"
+ # hardcoding other profile params to avoid profile override values
+ # More on Cargo profiles
https://doc.rust-lang.org/cargo/reference/profiles.html?profile-settings#profile-settings
+ RUSTFLAGS: "-C debuginfo=0 -C opt-level=0 -C incremental=false -C
codegen-units=256"
RUST_BACKTRACE: "1"
+ # avoid rust stack overflows on tpc-ds tests
+ RUST_MINSTACK: "3000000"
Review Comment:
that is true, during testing I saw spontaneous stack overflow issue on
physical q54 TPC-DS test, that was the reason to bump the stack size. But I
agree its good to create a follow up ticket and figure out why q54 is not the
same as others, maybe the bigger problem is behind it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
