Jefffrey commented on code in PR #8730:
URL: https://github.com/apache/arrow-datafusion/pull/8730#discussion_r1440971631
##########
.github/workflows/rust.yml:
##########
@@ -338,8 +352,12 @@ jobs:
cargo test --lib --tests --bins --all-features
env:
# do not produce debug symbols to keep memory usage down
- RUSTFLAGS: "-C debuginfo=0"
+ # hardcoding other profile params to avoid profile override values
+ # More on Cargo profiles
https://doc.rust-lang.org/cargo/reference/profiles.html?profile-settings#profile-settings
+ RUSTFLAGS: "-C debuginfo=0 -C opt-level=0 -C incremental=false -C
codegen-units=256"
RUST_BACKTRACE: "1"
+ # avoid rust stack overflows on tpc-ds tests
+ RUST_MINSTACK: "3000000"
Review Comment:
This feels like something we should fix in tpc-ds tests, instead of
accounting for it after the fact (I know I've had some trouble running those
tests locally due to stack issue, so could happen to others)
##########
.github/workflows/rust.yml:
##########
@@ -99,6 +99,14 @@ jobs:
rust-version: stable
- name: Run tests (excluding doctests)
run: cargo test --lib --tests --bins --features avro,json,backtrace
+ env:
+ # do not produce debug symbols to keep memory usage down
+ # hardcoding other profile params to avoid profile override values
+ # More on Cargo profiles
https://doc.rust-lang.org/cargo/reference/profiles.html?profile-settings#profile-settings
+ RUSTFLAGS: "-C debuginfo=0 -C opt-level=0 -C incremental=false -C
codegen-units=256"
Review Comment:
https://github.com/apache/arrow-datafusion/blob/1179a76567892b259c88f08243ee01f05c4c3d5c/.github/actions/setup-builder/action.yaml#L45-L50
I think some of these flags are already enabled, technically? Just for Linux
though, not Mac/Windows
(Well debuginfo was set to 0, not sure on incremental)
##########
.github/workflows/rust.yml:
##########
@@ -290,6 +298,7 @@ jobs:
# with a OS-dependent path.
- name: Setup Rust toolchain
run: |
+ rustup update stable
Review Comment:
Is the update here strictly necessary? Or should already be covered as part
of the toolchain install below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
