sgilmore10 commented on code in PR #39586: URL: https://github.com/apache/arrow/pull/39586#discussion_r1450883510
########## matlab/test/arrow/type/tDateTypeTest.m: ########## @@ -0,0 +1,80 @@ +% Shared superclass for DateType-related tests for Date32Type and Date64Type +classdef tDateType < matlab.unittest.TestCase Review Comment: The original `tDate32Type` and `tDate64Type` test classes inherited from `hFixedWidthType`. I would suggest having `tDateType` inherit from `hFixedWidthType`. That way, you get the test cases defined in hFixedWidthType class for "free". Additionally, I would suggest renaming this class to `hDateTypeTest.m` because its a helper test class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
