sgilmore10 commented on code in PR #39586: URL: https://github.com/apache/arrow/pull/39586#discussion_r1450886362
########## matlab/test/arrow/type/tDateTypeTest.m: ########## @@ -0,0 +1,80 @@ +% Shared superclass for DateType-related tests for Date32Type and Date64Type +classdef tDateType < matlab.unittest.TestCase + + properties Review Comment: Additionally, if this test class inherits from `hFixedWidthType`, you won't need to declare `ArrowType`, `TypeID`, `BitWidth`, or `ClassName`. These properties are declared as `Abstract` in `hFixedFixedType` and are concretely defined in `tDate32Type` and `tDate64Type`. I would also recommend declaring the `ConstructionFcn` `Abstract` so that child classes of this one must declare that property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
