sgilmore10 commented on code in PR #39586: URL: https://github.com/apache/arrow/pull/39586#discussion_r1450895226
########## matlab/test/arrow/type/tDateTypeTest.m: ########## @@ -0,0 +1,80 @@ +% Shared superclass for DateType-related tests for Date32Type and Date64Type +classdef tDateType < matlab.unittest.TestCase + + properties + ConstructionFcn + ArrowType + TypeID + BitWidth + ClassName + end + + methods (Test) + function TestClass(testCase) + % Verify ArrowType is an object of the expected class type. + name = string(class(testCase.ArrowType)); + testCase.verifyEqual(name, testCase.ClassName); + end + + function DefaultDateUnit(testCase) + type = testCase.ConstructionFcn(); + actualUnit = type.DateUnit; + expectedUnit = testCase.getDefaultDateUnit(); Review Comment: I recommend defining DefaultDateUnit as an abstract property that both `tDate32Type` and `tDate64Type` must definite concretely. This would be similar to how `hFixedWidthType` defines `Abstract` properties that its concrete child classes implement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
