tustvold commented on code in PR #5318:
URL: https://github.com/apache/arrow-rs/pull/5318#discussion_r1460433353
##########
arrow-json/src/writer.rs:
##########
@@ -1564,9 +1575,9 @@ mod tests {
r#"{"a":{"list":[1,2]},"b":{"list":[1,2]}}
{"a":{"list":[null]},"b":{"list":[null]}}
{"a":{"list":[]},"b":{"list":[]}}
-{"a":null,"b":{"list":[3,null]}}
+{"b":{"list":[3,null]}}
Review Comment:
The prior behaviour feels like a bug to me, without explicit nulls set I
would expect consistent use of implicit nulls. The fact that null objects
happen to be treated differently to null primitives seems at best confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
