tustvold commented on code in PR #5318:
URL: https://github.com/apache/arrow-rs/pull/5318#discussion_r1463895430
##########
arrow-json/test/data/basic.json:
##########
@@ -1,5 +1,5 @@
-{"a":1, "b":2.0, "c":false, "d":"4", "e":"1970-1-2", "f": "1.02", "g":
"2012-04-23T18:25:43.511", "h": 1.1}
-{"a":-10, "b":-3.5, "c":true, "d":"4", "e": "1969-12-31", "f": "-0.3", "g":
"2016-04-23T18:25:43.511", "h": 3.141}
+{"a":1, "b":2.0, "c":false, "d":"4", "e":"1970-1-2", "f": "1.02", "g":
"2012-04-23T18:25:43.511", "h": 1.2802734375}
Review Comment:
The previous writer had some questionable logic to truncate the precision of
its output. We no longer do this, and so we need to use a float that can
roundtrip be exactly represented in a f16 in order for it to roundtrip
precisely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
