Jefffrey commented on code in PR #9104:
URL: https://github.com/apache/arrow-datafusion/pull/9104#discussion_r1475866019
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -2242,7 +2242,7 @@ mod tests {
dict_id: 0, \
dict_is_ordered: false, \
metadata: {} } }\
- ], metadata: {}, functional_dependencies: FunctionalDependencies {
deps: [] } }, \
+ ], metadata: {}, functional_dependencies: FunctionalDependencies {
deps: [] }, fields_map: {\"a\": 0} }, \
Review Comment:
I suppose there's no easy way to omit this new field from debug
:slightly_frowning_face: (other than newtyping it?)
Not a big deal I guess
##########
datafusion/common/src/dfschema.rs:
##########
@@ -865,11 +880,13 @@ impl DFField {
/// Returns a string to the `DFField`'s qualified name
pub fn qualified_name(&self) -> String {
- if let Some(qualifier) = &self.qualifier {
- format!("{}.{}", qualifier, self.field.name())
- } else {
- self.field.name().to_owned()
- }
+ Self::make_qualified_name(self.qualifier.as_ref(), self.name())
+ }
+
+ pub fn make_qualified_name(qualifier: Option<&TableReference>, name: &str)
-> String {
Review Comment:
Probably doesn't need to be pub?
##########
datafusion/sqllogictest/test_files/information_schema.slt:
##########
@@ -115,14 +115,14 @@ datafusion information_schema schemata VIEW
datafusion information_schema tables VIEW
datafusion information_schema views VIEW
-query TTTT rowsort
-SELECT * from information_schema.tables WHERE
datafusion.information_schema.tables.table_schema='information_schema';
-----
-datafusion information_schema columns VIEW
-datafusion information_schema df_settings VIEW
-datafusion information_schema schemata VIEW
-datafusion information_schema tables VIEW
-datafusion information_schema views VIEW
+#query TTTT rowsort
+#SELECT * from information_schema.tables WHERE
datafusion.information_schema.tables.table_schema='information_schema';
+#----
+#datafusion information_schema columns VIEW
+#datafusion information_schema df_settings VIEW
+#datafusion information_schema schemata VIEW
+#datafusion information_schema tables VIEW
+#datafusion information_schema views VIEW
Review Comment:
Was there a reason this is being commented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
