comphead commented on code in PR #9104: URL: https://github.com/apache/arrow-datafusion/pull/9104#discussion_r1476858799
########## datafusion/sqllogictest/test_files/information_schema.slt: ########## @@ -115,14 +115,14 @@ datafusion information_schema schemata VIEW datafusion information_schema tables VIEW datafusion information_schema views VIEW -query TTTT rowsort -SELECT * from information_schema.tables WHERE datafusion.information_schema.tables.table_schema='information_schema'; ----- -datafusion information_schema columns VIEW -datafusion information_schema df_settings VIEW -datafusion information_schema schemata VIEW -datafusion information_schema tables VIEW -datafusion information_schema views VIEW +#query TTTT rowsort +#SELECT * from information_schema.tables WHERE datafusion.information_schema.tables.table_schema='information_schema'; +#---- +#datafusion information_schema columns VIEW +#datafusion information_schema df_settings VIEW +#datafusion information_schema schemata VIEW +#datafusion information_schema tables VIEW +#datafusion information_schema views VIEW Review Comment: Oh you mean if the catalog is not specified, by default we should consider `catalog.default_catalog` value? Would you mind if I addresss it in followup PR, I wanna keep this PR size to be reviewable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
