comphead commented on code in PR #9104:
URL: https://github.com/apache/arrow-datafusion/pull/9104#discussion_r1476800053
##########
datafusion/sqllogictest/test_files/information_schema.slt:
##########
@@ -115,14 +115,14 @@ datafusion information_schema schemata VIEW
datafusion information_schema tables VIEW
datafusion information_schema views VIEW
-query TTTT rowsort
-SELECT * from information_schema.tables WHERE
datafusion.information_schema.tables.table_schema='information_schema';
-----
-datafusion information_schema columns VIEW
-datafusion information_schema df_settings VIEW
-datafusion information_schema schemata VIEW
-datafusion information_schema tables VIEW
-datafusion information_schema views VIEW
+#query TTTT rowsort
+#SELECT * from information_schema.tables WHERE
datafusion.information_schema.tables.table_schema='information_schema';
+#----
+#datafusion information_schema columns VIEW
+#datafusion information_schema df_settings VIEW
+#datafusion information_schema schemata VIEW
+#datafusion information_schema tables VIEW
+#datafusion information_schema views VIEW
Review Comment:
Thanks @Jefffrey
ideally I think this query shouldn't work. While debugging I found the next
```
Error: SchemaError(FieldNotFound { field: Column { relation: Some(Full {
catalog: "datafusion", schema: "information_schema", table: "tables" }), name:
"table_schema" }, valid_fields: [Column { relation: Some(Partial { schema:
"information_schema", table: "tables" }), name: "table_catalog" }, Column {
relation: Some(Partial { schema: "information_schema", table: "tables" }),
name: "table_schema" }, Column { relation: Some(Partial { schema:
"information_schema", table: "tables" }), name: "table_name" }, Column {
relation: Some(Partial { schema: "information_schema", table: "tables" }),
name: "table_type" }] }, Some(""))
```
So DF asks fully qualified column name in the list of partially qualified
ones., imho this test shouldn't pass.
We typically allow less qualified to find a match for more qualified like `a
-> t1.a` or `a -> schema.t1.a` but not the opposite.
I'm open to discussions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
