Jefffrey commented on code in PR #9104:
URL: https://github.com/apache/arrow-datafusion/pull/9104#discussion_r1476848589


##########
datafusion/sqllogictest/test_files/information_schema.slt:
##########
@@ -115,14 +115,14 @@ datafusion information_schema schemata VIEW
 datafusion information_schema tables VIEW
 datafusion information_schema views VIEW
 
-query TTTT rowsort
-SELECT * from information_schema.tables WHERE 
datafusion.information_schema.tables.table_schema='information_schema';
-----
-datafusion information_schema columns VIEW
-datafusion information_schema df_settings VIEW
-datafusion information_schema schemata VIEW
-datafusion information_schema tables VIEW
-datafusion information_schema views VIEW
+#query TTTT rowsort
+#SELECT * from information_schema.tables WHERE 
datafusion.information_schema.tables.table_schema='information_schema';
+#----
+#datafusion information_schema columns VIEW
+#datafusion information_schema df_settings VIEW
+#datafusion information_schema schemata VIEW
+#datafusion information_schema tables VIEW
+#datafusion information_schema views VIEW

Review Comment:
   I think it should still work.
   
   If the default catalog is `datafusion`, then all tables that don't have a 
catalog specified should implicitly fall under `datafusion` catalog. So 
querying `information_schema.tables` is the same as querying 
`datafusion.information_schema.tables` which means we should be able to use 
`datafusion.information_schema.tables.table_schema` in the where clause and 
resolve it.
   
   I think I've worked on or seen an issue related to this before, and I agree 
it might be a bit confusing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to