peter-toth commented on PR #8891: URL: https://github.com/apache/arrow-datafusion/pull/8891#issuecomment-1933813296
> I think it would be more understandable for us and we would move faster if we agreed on each item one by one 😊. So, do you agree on converting Skip to Jump with this functionalities? Agreed. > "During top-down traversals, it means that the current subtree will be skipped, and if there exists another child subtree, the traversal is continued from there. If there does not, it means the same with the Stop, halts the traversal and collect all transformation till that node. During bottom-up traversals, Jump makes the walk on the current subtree skipped till the first multi-child node." Example scenario can be found on the design doc. > > This behavior will be the same for both transform and visitor/rewriter traversals. Because > During bottom-up traversals, Jump makes the walk on the current subtree skipped till the first multi-child node. differs to the current PR implementation (otherwise `Jump` is exactly what `Skip` in this PR does), may I ask you to show an example where this can be useful in bottom-up traversals? I'm asking because: - I don't see where this new functionality can be used, - and `TreeNodeRecursion::Skip` behaviour in this PR is alligned with the existing `VisitRecursion:Skip`, - and `TreeNodeRecursion::Skip` behavior is much simpler to describe and understand, see in description PR We can be more concreate, please see my question above: > I think this is 2nd image in your document. Do you have any usecase where it make sense to skip post_visit(D)? Also, I'm open to rename `Skip` to a better alternative. But, because `Jump` doesn't have any standard meaning in terms of tree traversal, I would suggest `Prune`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
