sunchao commented on code in PR #45:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/45#discussion_r1495274519
##########
common/pom.xml:
##########
@@ -80,7 +80,7 @@ under the License.
<plugin>
<groupId>io.github.git-commit-id</groupId>
<artifactId>git-commit-id-maven-plugin</artifactId>
- <version>5.0.0</version>
+ <version>4.9.9</version>
Review Comment:
why is this change?
##########
.github/actions/java-test/action.yaml:
##########
@@ -35,9 +35,17 @@ runs:
- name: Run Maven compile
shell: bash
run: |
- ./mvnw compile test-compile scalafix:scalafix -Psemanticdb
+ if [ $JAVA_VERSION == "8" ]; then
+ ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb
-Djava.version=1.8
+ else
+ ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb
-Djava.version=${JAVA_VERSION}
+ fi
- name: Run tests
shell: bash
run: |
- SPARK_HOME=`pwd` ./mvnw clean install
+ if [ $JAVA_VERSION == "8" ]; then
+ SPARK_HOME=`pwd` ./mvnw -B clean install -Djava.version=1.8
Review Comment:
can we just set `JAVA_VERSION` to `1.8` so we don't need this if-else
statement?
##########
.github/workflows/pr_build.yml:
##########
@@ -35,105 +35,99 @@ on:
workflow_dispatch:
env:
- JAVA_VERSION: 17
RUST_VERSION: nightly
jobs:
- linux-rust-test:
- name: Rust test (amd64)
- runs-on: ubuntu-latest
+ linux-java-or-rust-test:
Review Comment:
maybe just `linux-test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
