mustafasrepo commented on code in PR #9221:
URL: https://github.com/apache/arrow-datafusion/pull/9221#discussion_r1495565207
##########
datafusion/expr/src/expr.rs:
##########
@@ -1768,9 +1778,15 @@ fn create_name(e: &Expr) -> Result<String> {
window_frame,
partition_by,
order_by,
+ null_treatment,
}) => {
let mut parts: Vec<String> =
vec![create_function_name(&fun.to_string(), false, args)?];
+
+ if null_treatment.is_some() {
Review Comment:
You can use `if let Some() = null_treatment {}` pattern here. It would
eliminate `.unwrap`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
