comphead commented on PR #9221: URL: https://github.com/apache/arrow-datafusion/pull/9221#issuecomment-1954649437
Thanks @mustafasrepo for the detailed feedback. I'll remove leftovers not related to PR. My next steps: - add tests for LAG with non default offset - I'll try to use evaluate_all, it will be easier you are right as we have all data in place. The only thing concerns me when I run tests I didn't see `.evaluate_all` has been called - For the evaluate, I appreciate your help. One idea I had is to reverse input array before calling evaluate for only LEAD function and it potentially should work, but there reversing might be expensive -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
