comphead commented on PR #9221: URL: https://github.com/apache/arrow-datafusion/pull/9221#issuecomment-1958510885
@mustafasrepo thanks for suggestions, I've implemented similar approach with tracking nonnull row indexes, so likely it works for non default offset. I was not able to call LAG in `.evaluate_all` mode as it just not configured that way. https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/src/physical_planner.rs#L750 is the condition to select preferred mode. It will be always Bounded for LAG/LEAD because https://github.com/apache/arrow-datafusion/blob/cf11a700eb6a5385a6ebade2b92c684380940296/datafusion/physical-expr/src/window/built_in.rs#L276 refers to evaluator.supports_bounded_execution which is true for LAG/LEAD https://github.com/apache/arrow-datafusion/blob/cf11a700eb6a5385a6ebade2b92c684380940296/datafusion/physical-expr/src/window/lead_lag.rs#L234 and uses_window_frame is false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
