mustafasrepo commented on code in PR #9221:
URL: https://github.com/apache/arrow-datafusion/pull/9221#discussion_r1495590193
##########
datafusion/physical-expr/src/window/lead_lag.rs:
##########
@@ -204,17 +215,34 @@ impl PartitionEvaluator for WindowShiftEvaluator {
values: &[ArrayRef],
range: &Range<usize>,
) -> Result<ScalarValue> {
+ // TODO: try to get rid of i64 usize conversion
+ // TODO: do not recalc default value every call
Review Comment:
```suggestion
// TODO: do not recalculate default value every call
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
