alamb commented on PR #9410: URL: https://github.com/apache/arrow-datafusion/pull/9410#issuecomment-1973905963
> BTW, I wanted to modify the lexsort_to_indices function in [arrow-rs](https://github.com/apache/arrow-rs/compare/master...JasonLi-cn:arrow-rs:fix/lexsort_to_indices_bug), but after bench, I found that the Rows based implementation was better. I don't understand this statement -- it says you found the Rows based implementation was better but this PR proposes adding multi-column `lexsort_to_indices` in DataFusion. Wouldn't it be better to switch DataFusion to use a `Rows` based sort in this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
