JasonLi-cn commented on PR #9410: URL: https://github.com/apache/arrow-datafusion/pull/9410#issuecomment-1974432387
> Thank you @JasonLi-cn -- this is a good idea > > I filed #9418 to track this feature and updated this PR to mention it > > I think this PR needs: > > 1. SQL level end to end tests with multi column sorting with arrays -- perhaps you can adapt the example in [Support multi column sorting with lists #9418](https://github.com/apache/arrow-datafusion/issues/9418) and add an sqllogictest: https://github.com/apache/arrow-datafusion/tree/main/datafusion/sqllogictest > 2. Since this proposal actually changes all multi-column sorts (not just ones with `List`s) I think we need to run DataFusion benchmarks to make sure it isn't decreasing performance. > > Another approach we could potentially take is to only run this new codepath if there is a list (and there is more than one column) 1. I have added some SQL level end to end tests. 2. I refactor `sort_batch`: using RowConverter only when sorting multiple columns that contain a List -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
