tustvold commented on code in PR #9410:
URL: https://github.com/apache/arrow-datafusion/pull/9410#discussion_r1510031093
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -587,7 +590,13 @@ pub(crate) fn sort_batch(
.map(|expr| expr.evaluate_to_sort_column(batch))
.collect::<Result<Vec<_>>>()?;
- let indices = lexsort_to_indices(&sort_columns, fetch)?;
+ let indices = if is_multi_column_with_lists(&sort_columns) {
Review Comment:
FWIW I would anticipate the row format being faster for almost all multi
column sorts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]