alamb commented on code in PR #9410:
URL: https://github.com/apache/arrow-datafusion/pull/9410#discussion_r1509954476
##########
datafusion/sqllogictest/test_files/order.slt:
##########
@@ -784,3 +784,110 @@ SortPreservingMergeExec: [m@0 ASC NULLS LAST,t@1 ASC
NULLS LAST]
----------------AggregateExec: mode=Partial, gby=[1 as Int64(1), t@0 as t],
aggr=[], ordering_mode=PartiallySorted([0])
------------------ProjectionExec: expr=[column1@0 as t]
--------------------ValuesExec
+
+#####
Review Comment:
👍
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -587,7 +590,12 @@ pub(crate) fn sort_batch(
.map(|expr| expr.evaluate_to_sort_column(batch))
.collect::<Result<Vec<_>>>()?;
- let indices = lexsort_to_indices(&sort_columns, fetch)?;
+ let indices = if is_multi_column_with_lists(&sort_columns) {
+ // Ref: https://github.com/apache/arrow-rs/pull/2929
Review Comment:
I filed https://github.com/apache/arrow-rs/issues/5454 and
https://github.com/apache/arrow-rs/pull/5455 to track this issue better. This
particular link is to the benchmarks which may be confusing for future readers
```suggestion
// lex_sort_to_indices doesn't support List with more than one colum
// https://github.com/apache/arrow-rs/issues/5454
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
