erratic-pattern commented on code in PR #5433:
URL: https://github.com/apache/arrow-rs/pull/5433#discussion_r1511392897
##########
arrow-flight/tests/flight_sql_client_cli.rs:
##########
@@ -274,10 +303,17 @@ impl FlightSqlService for FlightSqlServiceImpl {
cmd: CommandPreparedStatementQuery,
_request: Request<FlightDescriptor>,
) -> Result<Response<FlightInfo>, Status> {
- assert_eq!(
- cmd.prepared_statement_handle,
- PREPARED_STATEMENT_HANDLE.as_bytes()
- );
+ if self.stateless_prepared_statements {
Review Comment:
I'd like to do this kind of testing (simulate both stateful and stateless
server behavior) in the Go implementation as well, but I am less confident
around the Arrow Go test suite and general Go testing practices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
