erratic-pattern commented on code in PR #5433:
URL: https://github.com/apache/arrow-rs/pull/5433#discussion_r1511571924
##########
arrow-flight/src/sql/client.rs:
##########
@@ -518,17 +520,36 @@ impl PreparedStatement<Channel> {
.await
.map_err(flight_error_to_arrow_error)?;
- self.flight_sql_client
+ let result = self
+ .flight_sql_client
.do_put(stream::iter(flight_data))
.await?
- .try_collect::<Vec<_>>()
+ .message()
.await
- .map_err(status_to_arrow_error)?;
+ .map_err(status_to_arrow_error)?
+ .unwrap();
+ // Attempt to update the stored handle with any updated handle in
the DoPut result.
+ // Not all servers support this, so ignore any errors when
attempting to decode.
Review Comment:
I've updated the logic here to not ignore legitimate errors and instead only
look for empty responses instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
