erratic-pattern commented on code in PR #5433:
URL: https://github.com/apache/arrow-rs/pull/5433#discussion_r1511389244
##########
arrow-flight/examples/flight_sql_server.rs:
##########
@@ -617,7 +618,7 @@ impl FlightSqlService for FlightSqlServiceImpl {
&self,
_query: CommandPreparedStatementQuery,
_request: Request<PeekableFlightDataStream>,
- ) -> Result<Response<<Self as FlightService>::DoPutStream>, Status> {
+ ) -> Result<Option<DoPutPreparedStatementResult>, Status> {
Review Comment:
Yes I think I had some confusion around whether or not the response should
now be mandatory in up-to-date servers, with the legacy behavior being
something only the client is concerned with.
But now I think making the new result explicitly optional helps to document
the legacy behavior and helps avoid confusion. So I will update interfaces to
reflect this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
