erratic-pattern commented on code in PR #5433:
URL: https://github.com/apache/arrow-rs/pull/5433#discussion_r1511576826
##########
arrow-flight/examples/flight_sql_server.rs:
##########
@@ -617,7 +618,7 @@ impl FlightSqlService for FlightSqlServiceImpl {
&self,
_query: CommandPreparedStatementQuery,
_request: Request<PeekableFlightDataStream>,
- ) -> Result<Response<<Self as FlightService>::DoPutStream>, Status> {
+ ) -> Result<Option<DoPutPreparedStatementResult>, Status> {
Review Comment:
This is a decision of whether or not we want to expressly forbid up-to-date
servers from implementing the older version of the spec, even though clients
still support it. I went with the more conservative decision of allowing
existing implementations to continue doing what they were doing before without
any major changes aside from changing their return value to `Ok(None)`. That
way they continue with the legacy behavior without being "locked out" of future
crate updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
