paleolimbot commented on code in PR #40365:
URL: https://github.com/apache/arrow/pull/40365#discussion_r1521537719


##########
cpp/src/arrow/testing/gtest_util.h:
##########
@@ -354,6 +354,13 @@ ARROW_TESTING_EXPORT
 std::shared_ptr<Table> TableFromJSON(const std::shared_ptr<Schema>&,
                                      const std::vector<std::string>& json);
 
+ARROW_TESTING_EXPORT
+std::shared_ptr<Tensor> TensorFromJSON(const std::shared_ptr<DataType>& type,
+                                       const std::vector<int64_t>& shape,
+                                       std::string_view json,
+                                       const std::vector<int64_t>& strides = 
{},
+                                       const std::vector<std::string>& 
dim_names = {});

Review Comment:
   Do you have access to nlohmann/json.hpp in the testing library? nanoarrow's 
testing library has a thing that parses an array of JSON integers (but it uses 
that JSON library and I'm not sure what you have access to already here).
   
   
https://github.com/apache/arrow-nanoarrow/blob/main/src/nanoarrow/nanoarrow_testing.hpp#L2191-L2218



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to