AlenkaF commented on code in PR #40365:
URL: https://github.com/apache/arrow/pull/40365#discussion_r1521547481
##########
cpp/src/arrow/testing/gtest_util.h:
##########
@@ -354,6 +354,13 @@ ARROW_TESTING_EXPORT
std::shared_ptr<Table> TableFromJSON(const std::shared_ptr<Schema>&,
const std::vector<std::string>& json);
+ARROW_TESTING_EXPORT
+std::shared_ptr<Tensor> TensorFromJSON(const std::shared_ptr<DataType>& type,
+ const std::vector<int64_t>& shape,
+ std::string_view json,
+ const std::vector<int64_t>& strides =
{},
+ const std::vector<std::string>&
dim_names = {});
Review Comment:
That's nano-neat Dewey! I did find the parse method in _nlohmann/json_ but
didn't want to use it as I am trying to stick to the methods we already use in
Arrow C++, if possible (yeah, no access to it). Not sure if I can solve it like
that though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
