AlenkaF commented on code in PR #40365:
URL: https://github.com/apache/arrow/pull/40365#discussion_r1522949639
##########
cpp/src/arrow/testing/gtest_util.h:
##########
@@ -354,6 +354,13 @@ ARROW_TESTING_EXPORT
std::shared_ptr<Table> TableFromJSON(const std::shared_ptr<Schema>&,
const std::vector<std::string>& json);
+ARROW_TESTING_EXPORT
+std::shared_ptr<Tensor> TensorFromJSON(const std::shared_ptr<DataType>& type,
+ const std::vector<int64_t>& shape,
+ std::string_view json,
+ const std::vector<int64_t>& strides =
{},
+ const std::vector<std::string>&
dim_names = {});
Review Comment:
> I assume this helper will only be used for testing?
Yes, correct.
I decided though to use `arrow/json/rapidjson_defs.h`
I also added `TensorFromJSON` with two different signatures. I would still
like to use strides as `std::vector<int64_t>` and not as `std::string_view` in
the tests for `RecordBatch::ToTensor` because I am not sure if hardcoding the
value of the size of tensor data type in bytes would be a good idea compared to
using `sizeof()` - in case there is a difference for other
compliers/architectures. It is quite possible I am complicating this =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
