rok commented on code in PR #40365:
URL: https://github.com/apache/arrow/pull/40365#discussion_r1522265021
##########
cpp/src/arrow/testing/gtest_util.h:
##########
@@ -354,6 +354,13 @@ ARROW_TESTING_EXPORT
std::shared_ptr<Table> TableFromJSON(const std::shared_ptr<Schema>&,
const std::vector<std::string>& json);
+ARROW_TESTING_EXPORT
+std::shared_ptr<Tensor> TensorFromJSON(const std::shared_ptr<DataType>& type,
+ const std::vector<int64_t>& shape,
+ std::string_view json,
+ const std::vector<int64_t>& strides =
{},
+ const std::vector<std::string>&
dim_names = {});
Review Comment:
We use `arrow/json/rapidjson_defs.h` for deserializing `FixedShapeTensor` -
[see
here](https://github.com/apache/arrow/blob/0ce72675f4dd755b2696eb6597850b21df647bb8/cpp/src/arrow/extension/fixed_shape_tensor.cc#L168-L177).
But I'd use `ArrayFromJSON` if it this if possible. I assume this helper will
only be used for testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
