pitrou commented on code in PR #40329:
URL: https://github.com/apache/arrow/pull/40329#discussion_r1526005401
##########
cpp/src/parquet/encryption/crypto_factory.h:
##########
@@ -148,7 +146,7 @@ class PARQUET_EXPORT CryptoFactory {
int dek_length, const std::string& column_keys, FileKeyWrapper*
key_wrapper);
/// Key utilities object for kms client initialization and cache control
- KeyToolkit key_toolkit_;
+ std::shared_ptr<KeyToolkit> key_toolkit_ = std::make_shared<KeyToolkit>();
Review Comment:
Is it desirable for this to be default-constructed? I suppose concrete use
requires a particular key toolkit, not a default-constructed one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
