pitrou commented on code in PR #40329:
URL: https://github.com/apache/arrow/pull/40329#discussion_r1526007386
##########
cpp/src/parquet/encryption/crypto_factory.cc:
##########
@@ -172,8 +199,8 @@ std::shared_ptr<FileDecryptionProperties>
CryptoFactory::GetFileDecryptionProper
const KmsConnectionConfig& kms_connection_config,
const DecryptionConfiguration& decryption_config, const std::string&
file_path,
const std::shared_ptr<::arrow::fs::FileSystem>& file_system) {
- auto key_retriever = std::make_shared<FileKeyUnwrapper>(
- &key_toolkit_, kms_connection_config,
decryption_config.cache_lifetime_seconds,
Review Comment:
I'm probably missing something, but why wouldn't change `FileKeyUnwrapper`
to accept an owning pointer instead?
##########
cpp/src/parquet/encryption/crypto_factory.cc:
##########
@@ -172,8 +199,8 @@ std::shared_ptr<FileDecryptionProperties>
CryptoFactory::GetFileDecryptionProper
const KmsConnectionConfig& kms_connection_config,
const DecryptionConfiguration& decryption_config, const std::string&
file_path,
const std::shared_ptr<::arrow::fs::FileSystem>& file_system) {
- auto key_retriever = std::make_shared<FileKeyUnwrapper>(
- &key_toolkit_, kms_connection_config,
decryption_config.cache_lifetime_seconds,
Review Comment:
I'm probably missing something, but why wouldn't we change
`FileKeyUnwrapper` to accept an owning pointer instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
