adamreeve commented on code in PR #40329:
URL: https://github.com/apache/arrow/pull/40329#discussion_r1526029254
##########
cpp/src/parquet/encryption/crypto_factory.cc:
##########
@@ -172,8 +199,8 @@ std::shared_ptr<FileDecryptionProperties>
CryptoFactory::GetFileDecryptionProper
const KmsConnectionConfig& kms_connection_config,
const DecryptionConfiguration& decryption_config, const std::string&
file_path,
const std::shared_ptr<::arrow::fs::FileSystem>& file_system) {
- auto key_retriever = std::make_shared<FileKeyUnwrapper>(
- &key_toolkit_, kms_connection_config,
decryption_config.cache_lifetime_seconds,
Review Comment:
Maybe this could work if `KeyToolkit` could inherit from
`std::enable_shared_from_this`, and we remove the public `KeyTookit`
constructor and enforce that it can only be created inside a `shared_ptr`? I'd
be concerned that this could be an annoying breaking change for some users
though if anyone is using `KeyToolkit` directly rather than via a
`CryptoFactory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
