adamreeve commented on code in PR #40329:
URL: https://github.com/apache/arrow/pull/40329#discussion_r1526020211
##########
cpp/src/parquet/encryption/crypto_factory.h:
##########
@@ -148,7 +146,7 @@ class PARQUET_EXPORT CryptoFactory {
int dek_length, const std::string& column_keys, FileKeyWrapper*
key_wrapper);
/// Key utilities object for kms client initialization and cache control
- KeyToolkit key_toolkit_;
+ std::shared_ptr<KeyToolkit> key_toolkit_ = std::make_shared<KeyToolkit>();
Review Comment:
I think this is fine. The `key_toolkit_` is always left as the default
constructed value, and it is initialized when
`CryptoFactory::RegisterKmsClientFactory` is called, which in turn calls
`key_toolkit_->RegisterKmsClientFactory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
