haohuaijin commented on PR #9595:
URL:
https://github.com/apache/arrow-datafusion/pull/9595#issuecomment-2009224462
Thanks @alamb and @jayzhan211 for reviews, your suggestions are very
helpful. I'm quite busy today, but I plan to apply the suggestions tomorrow.
> Figure out performance benchmarks (see below)
@alamb thanks for you benchmarks. Interestingly, I've also conducted same
benchmarks but my results seem to contradict yours. To understand our
discrepancies, could you please share the commands you used for your tests? For
reference, the commands I used are as follows:
```shell
git checkout main # the main branch in commit
b0b329ba39403b9e87156d6f9b8c5464dc6d2480
cargo bench --bench sql_planner -- --save-baseline main
git checkout feat/make-dfschema-wrap-schemaref
cargo bench --bench sql_planner -- --save-baseline 9595
critcmp main 9595
```
and the result is
```
group 9595
main
----- ----
----
logical_plan_tpch_all 1.00 55.0±28.58ms ?
?/sec 1.05 57.9±26.66ms ? ?/sec
logical_select_all_from_1000 1.00 20.9±0.54ms ?
?/sec 2.70 56.5±1.09ms ? ?/sec
physical_plan_tpch_all 1.00 119.9±31.55ms ?
?/sec 1.03 123.6±30.14ms ? ?/sec
physical_select_all_from_1000 1.00 133.5±2.16ms ?
?/sec 3.00 401.1±4.50ms ? ?/sec
```
> We should get some more viewers on this PR (post a note to the mailing
list as well as slack/discord)
can you help to do this in slack, I have no right to access arrow slack. I
already do this in mailing list and discord.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
