tustvold commented on code in PR #5525:
URL: https://github.com/apache/arrow-rs/pull/5525#discussion_r1531265651
##########
arrow-ipc/src/writer.rs:
##########
@@ -425,6 +430,8 @@ impl IpcDataGenerator {
compression_codec,
write_options,
)?;
+
+ set_variadic_buffer_counts(&mut variadic_buffer_counts, array);
Review Comment:
Instead of traversing the type hierarchy twice, what do you think about
adding this logic to write_array_data instead which already contains logic to
traverse nested types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
