XiangpengHao commented on code in PR #5525:
URL: https://github.com/apache/arrow-rs/pull/5525#discussion_r1532768618
##########
arrow-ipc/src/writer.rs:
##########
@@ -1247,6 +1315,17 @@ fn write_array_data(
compression_codec,
)?;
}
+ } else if matches!(data_type, DataType::BinaryView | DataType::Utf8View) {
+ // Todo: if the array has a offset, we should slice the ArrayData to
save space.
Review Comment:
Thanks for clarifying this, I've incorporated it in the code comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
