tustvold commented on code in PR #5525:
URL: https://github.com/apache/arrow-rs/pull/5525#discussion_r1532662643
##########
arrow-ipc/src/writer.rs:
##########
@@ -425,6 +430,8 @@ impl IpcDataGenerator {
compression_codec,
write_options,
)?;
+
+ set_variadic_buffer_counts(&mut variadic_buffer_counts, array);
Review Comment:
We could definitely do with lifting some of the arguments into a struct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
