XiangpengHao commented on code in PR #5525:
URL: https://github.com/apache/arrow-rs/pull/5525#discussion_r1532634707
##########
arrow-ipc/src/writer.rs:
##########
@@ -425,6 +430,8 @@ impl IpcDataGenerator {
compression_codec,
write_options,
)?;
+
+ set_variadic_buffer_counts(&mut variadic_buffer_counts, array);
Review Comment:
`write_array_data` is quite large and having 9 (will become 10) arguments
already. I can move the traversal to it for better clarity of this pr, but I
think this function is a refactoring candidate as it is quite complicated..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
